[MLIR] Tweak standalone example smoketest.py
#112448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir Author: Mateusz Sokół (mtsokol) ChangesHi! I think it might be useful to include them in the standalone build already. WDYT? Full diff: https://github.com/llvm/llvm-project/pull/112448.diff 2 Files Affected:
diff --git a/mlir/examples/standalone/python/CMakeLists.txt b/mlir/examples/standalone/python/CMakeLists.txt
index a8c43827a5a375..b948f4d524e0b5 100644
--- a/mlir/examples/standalone/python/CMakeLists.txt
+++ b/mlir/examples/standalone/python/CMakeLists.txt
@@ -43,7 +43,9 @@ add_mlir_python_common_capi_library(StandalonePythonCAPI
# TODO: Remove this in favor of showing fine grained registration once
# available.
MLIRPythonExtension.RegisterEverything
+ MLIRPythonExtension.ExecutionEngine
MLIRPythonSources.Core
+ MLIRPythonSources.Dialects
)
################################################################################
diff --git a/mlir/examples/standalone/test/python/smoketest.py b/mlir/examples/standalone/test/python/smoketest.py
index 08e08cbd2fe24c..3ea4283f8f41c2 100644
--- a/mlir/examples/standalone/test/python/smoketest.py
+++ b/mlir/examples/standalone/test/python/smoketest.py
@@ -1,7 +1,13 @@
# RUN: %python %s | FileCheck %s
from mlir_standalone.ir import *
-from mlir_standalone.dialects import builtin as builtin_d, standalone as standalone_d
+from mlir_standalone import execution_engine, passmanager
+from mlir_standalone.dialects import (
+ builtin as builtin_d,
+ linalg as linalg_d,
+ sparse_tensor as sparse_tensor_d,
+ standalone as standalone_d,
+)
with Context():
standalone_d.register_dialect()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While working with MLIR standalone example it took me some time to figure out how to access dialects and execution engine from MLIR Python package.
I think it might be useful to include them in the standalone build already. WDYT?